Fix OpenSSL::PKey::EC.new compatibility with openssl gem 3.0+#119
Open
yshmarov wants to merge 2 commits intorails:mainfrom
Open
Fix OpenSSL::PKey::EC.new compatibility with openssl gem 3.0+#119yshmarov wants to merge 2 commits intorails:mainfrom
yshmarov wants to merge 2 commits intorails:mainfrom
Conversation
OpenSSL::PKey::EC.new(pem_string) no longer accepts PEM/DER key strings since the openssl gem 3.0 (Ruby 3.2+). It now only accepts curve names, causing `OpenSSL::PKey::PKeyError: invalid curve name`. OpenSSL::PKey.read handles PEM/DER formats and is backwards-compatible. Fixes rails#118
Exercises the actual OpenSSL key loading path (previously fully stubbed) to ensure OpenSSL::PKey.read works with PEM-formatted EC keys.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OpenSSL::PKey::EC.new(pem_string)no longer accepts PEM/DER key strings since theopensslgem 3.0 (Ruby 3.2+). It now only accepts curve names (e.g.,"prime256v1"), causingOpenSSL::PKey::PKeyError: invalid curve namewhen generating APNs JWT tokens.OpenSSL::PKey.read(pem_string), which handles PEM/DER formats and is backwards-compatible with older Ruby versions.Test plan
access tokens are refreshed every 30 minutestest covers the token generation flow)Fixes #118