Create compaction planner service stub; wire up serving layer#6269
Open
nadav-govari wants to merge 3 commits intonadav/feature-split-mergesfrom
Open
Create compaction planner service stub; wire up serving layer#6269nadav-govari wants to merge 3 commits intonadav/feature-split-mergesfrom
nadav-govari wants to merge 3 commits intonadav/feature-split-mergesfrom
Conversation
nadav-govari
commented
Apr 6, 2026
Comment on lines
+293
to
+296
| if node_config.is_service_enabled(QuickwitService::Janitor) { | ||
| info!("compaction service enabled on this node"); | ||
| return Some(CompactionServiceClient::new(StubCompactionService)); | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
The janitor doesnt care -only indexers do.
| "compaction service is enabled but no janitor node was found in the cluster, falling \ | ||
| back to local merge pipelines" | ||
| ); | ||
| return None; |
Collaborator
Author
There was a problem hiding this comment.
Consider failing here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A lot of boilerplate in this PR.
Adds the compaction service gRPC layer. It's a stub.
Initializes the gRPC server for the janitor if an env var is set. On indexers, try to connect to this server: if successful, indexing pipelines dont start a merge service. If its not, for any reason, they do.
The rest is hooking this up and adding tests for the various logic added.
How was this PR tested?
Tested with a local quickwit cluster, and by adding unit and integration tests.