Skip to content

added JSON.parse source text access#1423

Merged
saghul merged 1 commit intomasterfrom
rawjson
Mar 27, 2026
Merged

added JSON.parse source text access#1423
saghul merged 1 commit intomasterfrom
rawjson

Conversation

@saghul
Copy link
Copy Markdown
Contributor

@saghul saghul commented Mar 26, 2026

No description provided.

Copy link
Copy Markdown
Contributor

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

DEF(global, "global")
DEF(unicode, "unicode")
DEF(raw, "raw")
DEF(rawJSON, "rawJSON")
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this triggers a need to rebuild the bytecode, shall we update the BC version? It feels like any change which requires a rebuild should incurr in a BC bump.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but does the bytecode also change when you put it at the end?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I'll double check!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No dice, it does.

@saghul saghul force-pushed the rawjson branch 2 times, most recently from f5bbc24 to bbe85ce Compare March 27, 2026 21:00
@saghul saghul merged commit 83bd236 into master Mar 27, 2026
122 checks passed
@saghul saghul deleted the rawjson branch March 27, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants