Open
Conversation
- runtimelib: 1.0 → 1.4 - jupyter-protocol: 1.0 → 1.4
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This upgrades
runtimelibfrom 1.0 to 1.4 and upgradesjupyter-protocolfrom 1.0 to 1.4.You can view the full
jupyter-protocolcrate CHANGELOG on GitHub. The main changes are improved compatibility with kernels that omit or deivate from spec required fields. There's more defensive deserialization for those cases.On the runtimelib side,
.split()is now supported on the Jupyter shell channel to make it so reader and writer can be owned separately. I haven't looked at your code deeply enough to see if you can make use of it. Within Zed and Deno it made the code cleaner and allowed us to drop extra tasks and channels.On the nbformat side, it now supports v3 notebook parsing and upconversion to v4. There are also some fixes to handle both string and array for cell source (noticed with how JetBrains writes out notebooks, still valid nbformat).