gh-62480: Remove first-person language from heapq documentation #144665
+3
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
awaiting review
docs
bBlazewavE
changed the title
StanFromIreland
requested changes
Feb 10, 2026
Member
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
These changes make little sense, I'm afraid.
Doc/library/heapq.rst
Outdated
|
|
||
| In a word, heaps are useful memory structures to know. I use them in a few | ||
| applications, and I think it is good to keep a 'heap' module around. :-) | ||
| In a word, heaps are useful memory structures to know. They are used in a number |
Member
There was a problem hiding this comment.
This doesn’t really make much sense now, a thought, maybe we could make this a quote?
Doc/library/heapq.rst
Outdated
| execution, they are scheduled into the future, so they can easily go into the | ||
| heap. So, a heap is a good structure for implementing schedulers (this is what | ||
| I used for my MIDI sequencer :-). | ||
| was used for the MIDI sequencer in the standard library). |
Member
There was a problem hiding this comment.
What "MIDI sequencer in the standard library"?
Author
There was a problem hiding this comment.
Remove the MIDI sequencer reference entirely?
Member
|
Please do not use the Update Branch button unless necessary (e.g. fixing conflicts, jogging the CI, or very old PRs) as it uses valuable resources. For more information see the devguide. |
Address review feedback: drop the remainder of the sentence after "heaps are useful memory structures to know" to avoid awkward impersonal rewording of the original first-person text.
Address review feedback: the parenthetical claimed a MIDI sequencer exists in the standard library, which it does not. Drop the reference and keep the sentence concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace first-person pronouns ("I", "my") with impersonal alternatives in the heapq module Theory section. Also removed "Believe me" from the footnote.
Relates to #62480.
📚 Documentation preview 📚: https://cpython-previews--144665.org.readthedocs.build/