Skip to content

gh-144639: Ruff: target Python 3.14 syntax in Lib/test #144656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hugovk wants to merge 2 commits into
base: main
Choose a base branch
from
+2 −12
Open

gh-144639: Ruff: target Python 3.14 syntax in Lib/test #144656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c891d75
Ruff: target Python 3.14 syntax in Lib/test
hugovk Feb 10, 2026
d97cd97
Add comment to explain target-version
hugovk Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions Lib/test/.ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
extend = "../../.ruff.toml" # Inherit the project-wide settings

target-version = "py312"
target-version = "py314" # unlike `Tools/`, tests can use newer syntax than `PYTHON_FOR_REGEN`

extend-exclude = [
# Excluded (run with the other AC files in its own separate ruff job in pre-commit)
Expand All @@ -15,15 +14,6 @@ extend-exclude = [
"test_grammar.py",
]

[per-file-target-version]
# Type parameter defaults
"test_type_params.py" = "py313"

# Template string literals
"test_annotationlib.py" = "py314"
"test_string/test_templatelib.py" = "py314"
"test_tstring.py" = "py314"

[lint]
select = [
"F401", # Unused import
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/support/import_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def make_legacy_pyc(source, allow_compile=False):
try:
pyc_file = importlib.util.cache_from_source(source)
shutil.move(pyc_file, legacy_pyc)
except (FileNotFoundError, NotImplementedError):
except FileNotFoundError, NotImplementedError:
Copy link
Member

@picnixz picnixz Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this specific change? (or is it a ruff change?)

Copy link
Member Author

@hugovk hugovk Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a manual change.

Please see the linked issue: @brettcannon had suggested it in a PR (#144293) but it had to be reverted because our tools wouldn't let us use 3.14 syntax in 3.15 tests.

if not allow_compile:
raise
py_compile.compile(source, legacy_pyc, doraise=True)
Expand Down
Loading