gh-144490: Fix mimalloc debug build

[yoney]

Fix mimalloc C++ compilation error in debug builds.

The _mi_assert_fail declaration uses mi_decl_throw, which expands to __THROW (for __GNUC__ ). In C, __THROW is __attribute__((__nothrow__)) and works anywhere. In C++, __THROW is noexcept(true), which must come after the parameter list.

Before:

  // C:   __attribute__((__nothrow__)) void _mi_assert_fail(...);
  // C++: noexcept(true) void _mi_assert_fail(...);  <- Error, noexcept(...) must be after the params

After:

  // C:   void _mi_assert_fail(...) __attribute__((__nothrow__));
  // C++: void _mi_assert_fail(...) noexcept(true);

This fix also allows removing the Py_DEBUG guard in test_cppext/extension.cpp, so internal C API headers are now tested in debug builds too.

It’s possible this issue was introduced in #122587, though I haven’t verified it

Test:

$ ./configure --with-pydebug --disable-gil
$ make
$ ./python -m test test.test_cppext -u cpu=1

cc: @vstinner @colesbury @DinoV

• Issue: Enhancement request: make pycore_cell.h compile cleanly under C++ #144490

[kumaraditya303]

Does this issue exists in mimalloc upstream as well?

[yoney]

Does this issue exists in mimalloc upstream as well?

It looks like upstream fixed this earlier. The change is semantically the same: they just moved mi_attr_noexcept to the end. However, the naming differs, our code uses mi_decl_throw, while upstream uses mi_attr_noexcept.

microsoft/mimalloc@715acc0

[vstinner]

LGTM. I confirm that test_cppext.TestInteralCAPI pass on Linux with Python built in debug mode.

[vstinner]

Note: test_cppext.TestInteralCAPI fails on Windows with Python built in release mode if I remove # if !defined(MS_WINDOWS) in Lib/test/test_cppext/extension.cpp. The change is correct: we should continue skipping the two pycore includes on Windows.

[miss-islington-app]

Thanks @yoney for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[miss-islington-app]

Sorry, @yoney and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 73fa6be2fe6c4a17d91413e12ab6af8376767211 3.14

[vstinner]

Ah, the 3.14 branch is not affected, since the _mi_assert_fail() declaration doesn't use mi_decl_throw:

void _mi_assert_fail(const char* assertion, const char* fname, unsigned int line, const char* func );

[vstinner]

Merged, thanks.