Skip to content

Conversation

@fuhsnn
Copy link

@fuhsnn fuhsnn commented Jul 12, 2024

If _Py_TYPEOF is undefined, Py_CLEAR falls back to an implementation with memcpy() call; conditionally include the missing string.h dependency.

…efined

If _Py_TYPEOF is undefined, Py_CLEAR falls back to an implementation with memcpy() call; conditionally include the missing string.h dependency.
@ghost
Copy link

ghost commented Jul 12, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jul 12, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is outdated: the pwd extension is no longer built with the limited C API.

Also, it's not the proper fix: Python.h should include <string.h> if the _Py_TYPEOF macro is not defined. I wrote #144666 change to do that.

@bedevere-app
Copy link

bedevere-app bot commented Feb 10, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@vstinner vstinner closed this Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants