docs(fmodata): fix intent install command#145
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
8d5df3f to
66eb384
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRemoved the AI Agent Integration section from Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
@proofkit/better-auth
@proofkit/cli
create-proofkit
@proofkit/fmdapi
@proofkit/fmodata
@proofkit/typegen
@proofkit/webviewer
commit: |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@apps/docs/content/docs/fmodata/quick-start.mdx`:
- Line 30: Replace the deprecated execPackage prop on the CliCommand component
with the packageName prop: locate the CliCommand instance that uses
execPackage="@tanstack/intent@latest" (the install command) and change the prop
name to packageName while keeping the same value so it becomes
packageName="@tanstack/intent@latest" to match other CliCommand usages.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: beb1dacb-3e0f-406a-a5f7-b84cb8099a9d
📒 Files selected for processing (2)
apps/docs/content/docs/fmodata/index.mdxapps/docs/content/docs/fmodata/quick-start.mdx
| } | ||
| return pkg.includes("@"); | ||
| }; | ||
| const shouldAppendVersion = packageName.startsWith("@proofkit/") && !hasVersionSpecifier(packageName); |
There was a problem hiding this comment.
Runtime error: packageName is optional but accessed without null check. When packageName is undefined, calling .startsWith() will throw TypeError: Cannot read property 'startsWith' of undefined.
Fix by adding a null check:
const shouldAppendVersion = packageName?.startsWith("@proofkit/") && !hasVersionSpecifier(packageName);Or use a guard clause:
const shouldAppendVersion = packageName && packageName.startsWith("@proofkit/") && !hasVersionSpecifier(packageName);| const shouldAppendVersion = packageName.startsWith("@proofkit/") && !hasVersionSpecifier(packageName); | |
| const shouldAppendVersion = packageName?.startsWith("@proofkit/") && !hasVersionSpecifier(packageName); |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
apps/docs/src/app/docs/(docs)/layout.tsx (1)
19-19: Minor inconsistency withrelattribute.This link uses
rel="noopener"while the equivalent link intemplates/layout.tsxusesrel="noopener noreferrer". Consider addingnoreferrerfor consistency and additional referrer privacy.Suggested fix
- <a className="underline" href="https://proofgeist.com" rel="noopener" target="_blank"> + <a className="underline" href="https://proofgeist.com" rel="noopener noreferrer" target="_blank">🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/docs/src/app/docs/`(docs)/layout.tsx at line 19, Update the anchor element in docs/(docs)/layout.tsx that currently uses rel="noopener" to use rel="noopener noreferrer" for parity with templates/layout.tsx; locate the <a className="underline" href="https://proofgeist.com" rel="noopener" target="_blank"> element and change its rel attribute to "noopener noreferrer" to add referrer privacy and maintain consistency.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/docs/src/app/docs/`(docs)/layout.tsx:
- Line 19: Update the anchor element in docs/(docs)/layout.tsx that currently
uses rel="noopener" to use rel="noopener noreferrer" for parity with
templates/layout.tsx; locate the <a className="underline"
href="https://proofgeist.com" rel="noopener" target="_blank"> element and change
its rel attribute to "noopener noreferrer" to add referrer privacy and maintain
consistency.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 74c3111c-9c66-4189-a75f-2bc611f5422c
📒 Files selected for processing (2)
apps/docs/src/app/docs/(docs)/layout.tsxapps/docs/src/app/docs/templates/layout.tsx
…tent docs link Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Summary by CodeRabbit