Change XHR request URL to base CP URL#23
Open
bencroker wants to merge 1 commit intopresseddigital:masterfrom
Open
Change XHR request URL to base CP URL#23bencroker wants to merge 1 commit intopresseddigital:masterfrom
bencroker wants to merge 1 commit intopresseddigital:masterfrom
Conversation
Change XHR request URL to base CP URL.
|
+1 for this request. It's really stopping clients using plugin as filters don't appear in most cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Front-end action URL requests are treated differently than control panel action URL requests. Snaptcha, for example, blocks all POST requests to the front-end that do not contain a validation field value. CP requests however are not validated because the user is assumed to anyway be authenticated.
Since XHR calls to
searchit/element-filters/getare valid for the CP only, this pull request changes the XHR request from the front-end URL to the base CP URL for more consistent behaviour. I hope you'll consider it :)