Skip to content

feat: support IntelliJ IDEA open-in launch#1673

Merged
juliusmarminge merged 2 commits intopingdotgg:mainfrom
cenumi:main
Apr 2, 2026
Merged

feat: support IntelliJ IDEA open-in launch#1673
juliusmarminge merged 2 commits intopingdotgg:mainfrom
cenumi:main

Conversation

@cenumi
Copy link
Copy Markdown
Contributor

@cenumi cenumi commented Apr 2, 2026

What Changed

  • Added IntelliJ IDEA to the “Open in” picker in the web UI.
  • Refactored editor launch config from supportsGoto boolean to a launchStyle model so different editors can express their actual CLI behavior.
  • Updated server-side editor launch resolution to support three navigation modes:
    • direct path
    • --goto
    • --line/--column
  • Changed Antigravity's launchStyle to goto.
  • Added coverage for IntelliJ IDEA launch behavior and the per-editor argument handling logic.

Why

The old editor-launch model was too limited. A single supportsGoto flag only works for editors that accept --goto, which breaks down as soon as an editor uses a different CLI contract.

This PR fixes that design flaw instead of piling on another hack:

  • IntelliJ IDEA is now supported.
  • Existing editors keep their expected behavior.
  • The launch logic is more explicit, maintainable, and easier to extend for future editors.

UI Changes

  • Added IntelliJ IDEA as a new option in the “Open in” picker.

Before

image

After

image

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Medium risk because it changes shared editor contracts and server-side argument construction for multiple editors, which could break open-in-editor behavior if CLI expectations differ across platforms.

Overview
Adds IntelliJ IDEA as a supported EditorId and exposes it in the web “Open in” picker (including a new IntelliJIdeaIcon).

Replaces the supportsGoto flag with a launchStyle model (direct-path, goto, line-column) and refactors server-side resolveEditorLaunch to build editor-specific CLI args accordingly (including parsing path:line:column targets). Updates tests to cover IDEA’s --line/--column behavior and the new per-editor launch-style routing (including antigravity now using --goto).

Written by Cursor Bugbot for commit 648e204. This will update automatically on new commits. Configure here.

Note

Add IntelliJ IDEA as a supported editor with --line/--column navigation

  • Adds idea to the EDITORS list in editor.ts with launchStyle: 'line-column', making it a valid EditorId.
  • Replaces the boolean supportsGoto field with a launchStyle discriminant ('direct-path', 'goto', or 'line-column') across all editor definitions.
  • Introduces resolveCommandEditorArgs in open.ts to build CLI args per launch style, replacing the previous shouldUseGotoFlag logic.
  • Adds an IntelliJIdeaIcon component to Icons.tsx and surfaces an IntelliJ IDEA option in the OpenInPicker.
  • Behavioral Change: Zed now uses direct-path (no --goto) and all previously supportsGoto: true editors retain equivalent goto behavior.

Macroscope summarized 648e204.

Add editor-specific launch styles for direct path, --goto,
and line/column arguments.

Expose IntelliJ IDEA in the open-in picker and cover the
new launch behavior with server tests
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8cdeaaea-154e-4580-bf01-01ed0abb3021

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Apr 2, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 2, 2026

Approvability

Verdict: Approved

This PR adds IntelliJ IDEA as a new editor option with appropriate command-line argument handling. The changes are additive with good test coverage, and the refactor from boolean supportsGoto to enum launchStyle is mechanical and preserves existing behavior for all current editors.

You can customize Macroscope's approvability policy. Learn more.

Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works. Given that idea is not installed by default and you gotta follow their guide here: https://www.jetbrains.com/help/idea/working-with-the-ide-features-from-command-line.html#standalone

@juliusmarminge juliusmarminge enabled auto-merge (squash) April 2, 2026 23:54
@juliusmarminge juliusmarminge merged commit 1b272fd into pingdotgg:main Apr 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants