Fix supervised approval command visibility#1660
Draft
juliusmarminge wants to merge 1 commit intomainfrom
Draft
Conversation
Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
Supervisor mode approvals need the full command to be readable before the user approves it. Showing the command as low-contrast placeholder text made it hard to review and could visually cut off long commands.
UI Changes
supervised_approval_command_visibility.mp4
Supervised approval command visibility
Checklist
To show artifacts inline, enable in settings.
Note
Fix supervised approval command visibility in
ComposerPendingApprovalPanelComposerPendingApprovalPanel.tsxthat rendersapproval.detailin a wrapped, scrollable, selectable monospace<pre>element when present, with a label derived fromrequestKind('Command', 'Requested path', or 'Requested changes').ChatView.tsxso the composer placeholder always shows 'Resolve this approval request to continue' instead of leaking the raw approval detail string into the input placeholder.ChatView.browser.tsxthat verifies the detail block renders with correct text, wrapping style, and visible color.Macroscope summarized 8f6690f.