Skip to content

Fix supervised approval command visibility#1660

Draft
juliusmarminge wants to merge 1 commit intomainfrom
cursor/issue-resolution-7dc1
Draft

Fix supervised approval command visibility#1660
juliusmarminge wants to merge 1 commit intomainfrom
cursor/issue-resolution-7dc1

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 1, 2026

What Changed

  • Render pending approval command details in a dedicated wrapped, selectable block inside the composer header instead of using the disabled editor placeholder.
  • Keep the approval-state editor placeholder as neutral helper copy.
  • Add a focused browser regression test that mounts a pending approval and verifies the command block is readable.

Why

Supervisor mode approvals need the full command to be readable before the user approves it. Showing the command as low-contrast placeholder text made it hard to review and could visually cut off long commands.

UI Changes

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

To show artifacts inline, enable in settings.

Open in Web Open in Cursor 

Note

Fix supervised approval command visibility in ComposerPendingApprovalPanel

  • Adds a labeled detail block to ComposerPendingApprovalPanel.tsx that renders approval.detail in a wrapped, scrollable, selectable monospace <pre> element when present, with a label derived from requestKind ('Command', 'Requested path', or 'Requested changes').
  • Fixes ChatView.tsx so the composer placeholder always shows 'Resolve this approval request to continue' instead of leaking the raw approval detail string into the input placeholder.
  • Adds a browser test in ChatView.browser.tsx that verifies the detail block renders with correct text, wrapping style, and visible color.

Macroscope summarized 8f6690f.

Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: db344e9c-719a-464a-9ec3-6fe7d24bf453

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/issue-resolution-7dc1

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants