[codex] Break web composer circular dependency#1659
Open
PlunderStruck wants to merge 2 commits intopingdotgg:mainfrom
Open
[codex] Break web composer circular dependency#1659PlunderStruck wants to merge 2 commits intopingdotgg:mainfrom
PlunderStruck wants to merge 2 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
apps/web/src/composerProviderState.tscomposerProviderRegistry.tsxback to traits rendering onlydocs/web-circular-deps-plan.mdWhy
ctx-analysis.mdand the live dependency graph both identified a real web import cycle throughcomposerDraftStore.ts,modelSelection.ts,composerProviderRegistry.tsx, andTraitsPicker.tsxmodelSelection.tspull chat UI and store setup into non-UI code pathsImpact
Validation
bun fmtbun lintbun typecheckbun run testmodelSelection.tsnow depends oncomposerProviderState.tsinstead of the chat registryNote
Break circular dependency by extracting
getComposerProviderStateinto a standalone modulegetComposerProviderState,ComposerProviderState, andComposerProviderStateInputout of composerProviderRegistry.tsx into a new composerProviderState.ts module.composerProviderRegistrynow only contains UI rendering logic (renderTraitsMenuContent,renderTraitsPicker), dropping all state-computation imports.Macroscope summarized 5415598.
Note
Low Risk
Low risk refactor that primarily moves provider-state normalization into a standalone module; main risk is subtle behavioral drift in model option normalization or ultrathink styling if the extraction missed edge cases.
Overview
Breaks a web circular dependency by extracting the pure composer provider-state normalization (
getComposerProviderStateand related types) into a newapps/web/src/composerProviderState.tsmodule.Updates non-UI callers (
modelSelection.ts,ChatView.tsx) to import the new helper directly, and trimscomposerProviderRegistry.tsxdown to traits UI rendering only. Provider-state tests are repointed to the new module, and a newdocs/web-circular-deps-plan.mddocuments the dependency cycle and verification steps.Written by Cursor Bugbot for commit 5415598. This will update automatically on new commits. Configure here.