Skip to content

[codex] finish effect fn checklist#1644

Draft
juliusmarminge wants to merge 1 commit intomainfrom
codex/effect-fn-docs-effect-fn-checklist
Draft

[codex] finish effect fn checklist#1644
juliusmarminge wants to merge 1 commit intomainfrom
codex/effect-fn-docs-effect-fn-checklist

Conversation

@juliusmarminge
Copy link
Copy Markdown
Member

@juliusmarminge juliusmarminge commented Apr 1, 2026

Summary

  • mark docs/effect-fn-checklist.md complete for the original checklist scope
  • note that the follow-up exact () => Effect.gen(...) scan also migrated apps/server/src/terminal/Layers/Manager.ts

Why

  • keep the migration checklist accurate after the remaining file work was split into one-file PRs
  • document that the post-checklist scan for newly introduced exact-empty-arg wrappers came back clean after the final migration

Validation

  • bun fmt
  • bun lint
  • exact scan: rg -n -U --multiline --glob '!*.test.ts' --glob '!docs/effect-fn-checklist.md' '\(\)\s*=>\s*\n\s*Effect\.gen\(function\*|\(\)\s*=>\s*Effect\.gen\(function\*' apps packages

Notes

  • validation was run from the completed checklist scratch branch before splitting these per-file PRs
  • bun run test and bun typecheck at the repo root currently fail in apps/web because @effect/atom-react cannot be resolved
  • apps/server still has unrelated pre-existing typecheck failures outside this file

Note

Mark effect fn migration checklist as complete in docs

Updates effect-fn-checklist.md to reflect that all effect function migrations are done. Marks completed items across all major components (ClaudeAdapter, ProviderService, OrchestrationEngine, EventNdjsonLogger, CodexAdapter, CheckpointStore, cli.ts handlers, projector.ts, and the smaller clusters section), and adds a summary note about a follow-up migration task.

Macroscope summarized 92b4ee8.

Co-authored-by: codex <codex@users.noreply.github.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9db87f57-f766-4dcc-96d7-9e0649787ba3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/effect-fn-docs-effect-fn-checklist

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant