-
Notifications
You must be signed in to change notification settings - Fork 551
Fix invokable objects incorrectly labeled as instances of Closure
#4797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a02e586 to
6d1e13c
Compare
47220f6 to
f59887e
Compare
staabm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one nit - LGTM otherwise.
thank you
| @@ -0,0 +1,25 @@ | |||
| <?php declare(strict_types=1); | |||
|
|
|||
| namespace Bug139752; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should not use a bug number of a different problem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This number seems high 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦♂️ Of course, fixed.
staabm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
|
@staabm Thank you for the help 😄 |
Closes phpstan/phpstan#13975