Skip to content

chore: pin external GitHub Actions to commit SHAs #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joel-phantom wants to merge 1 commit into from
Closed

chore: pin external GitHub Actions to commit SHAs #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/android-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,22 +13,22 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 20
cache: 'yarn'
- name: Set up JDK
uses: actions/setup-java@v4
uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 # v4
with:
distribution: temurin
java-version: 17
- name: Install npm dependencies
run: yarn --frozen-lockfile
shell: bash
- name: Build Android test app
uses: gradle/gradle-build-action@v2
uses: gradle/gradle-build-action@a8f75513eafdebd8141bd1cd4e30fcd194af8dfa # v2
with:
gradle-version: wrapper
arguments: -PnewArchEnabled=${{matrix.newArchEnabled}} --no-daemon clean build check test
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/detox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ jobs:
runs-on: 'macOS-latest'
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 20
cache: 'yarn'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ios-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ jobs:
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 20
cache: 'yarn'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/macos-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ jobs:
runs-on: macos-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- name: Set up Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: 20
cache: 'yarn'
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ jobs:
pull-requests: write
steps:
- name: Checkout Repo
uses: actions/checkout@v4
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4

- name: Enable Corepack
run: corepack enable

- name: Setup Node.js 20.x
uses: actions/setup-node@v3
uses: actions/setup-node@3235b876344d2a9aa001b8d1453c930bba69e610 # v3
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🌐 Web query:

Is actions/setup-node v3 still actively maintained, and are there any official recommendations to migrate workflows from v3 to v4?

💡 Result:

No, actions/setup-node v3 is not actively maintained. The last release for v3 was v3.0.0 in February 2022. Active development and releases are on v6 (latest v6.3.0 in March 2026), with v4, v5, and v6 receiving updates including dependency bumps and feature enhancements into 2026. Official documentation and examples use v6, and GitHub Docs recommend v4 or later. Yes, there are official recommendations to migrate from v3 to v4 (and newer). The repository README lists breaking changes for v4, v5, v6, implying migration from older versions like v3. Issues and deprecation notices for older versions (e.g., v2 relying on deprecated cache) urge upgrading to v4. GitHub Docs examples use actions/setup-node@v4. Stack Overflow and issues highlight Node 16 deprecation in v3 actions, recommending v4 which uses Node 20+.

Citations:

🏁 Script executed:

#!/bin/bash
# Find all workflow files and check setup-node versions
find .github/workflows -type f -name "*.yml" -o -name "*.yaml" | while read file; do
  echo "=== $file ==="
  grep -n "setup-node" "$file" || echo "(no setup-node found)"
done

Repository: phantom/react-native-webview

Length of output: 851

Upgrade actions/setup-node from v3 to v4 for consistency and maintenance.

The release workflow uses setup-node@v3, which has been unmaintained since February 2022. All other CI workflows (android-ci, detox, ios-ci, macos-ci, windows-ci) use v4, which receives ongoing updates and supports Node.js 20+. Aligning to v4 removes the maintenance drift and aligns with GitHub's official recommendations for migration.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/release.yml at line 25, Update the GitHub Actions step
that references the setup-node action so it uses the v4 release; locate the line
containing "uses: actions/setup-node@..." in the release workflow and change the
reference from v3 to v4 (e.g., actions/setup-node@v4) so the release.yml aligns
with other CI workflows and receives ongoing updates and Node.js 20+ support.

with:
node-version: 20.x

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
stale:
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v3.0.14
- uses: actions/stale@87c2b794b9b47a9bec68ae03c01aeb572ffebdb1 # v3.0.14
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'Hello 👋, this issue has been opened for more than 2 months with no activity on it. If the issue is still here, please keep in mind that we need community support and help to fix it! Just comment something like _still searching for solutions_ and if you found one, please open a pull request! You have 7 days until this gets closed automatically'
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/windows-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,17 @@ jobs:
runs-on: windows-2022

steps:
- uses: actions/checkout@v4
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
name: Checkout Code

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
with:
node-version: '20'
cache: 'yarn'

- name: Setup MSBuild
uses: microsoft/setup-msbuild@v1.1.3
uses: microsoft/setup-msbuild@34cfbaee7f672c76950673338facd8a73f637506 # v1.1.3
with:
vs-version: '[17.0,)'
msbuild-architecture: x64
Expand Down
Loading