Skip to content

fix(propose): require shell-safe PR body handling#118

Merged
pentaxis93 merged 1 commit intomainfrom
issue-116/fix-propose-require-shell-safe-pr-body
Mar 10, 2026
Merged

fix(propose): require shell-safe PR body handling#118
pentaxis93 merged 1 commit intomainfrom
issue-116/fix-propose-require-shell-safe-pr-body

Conversation

@pentaxis93
Copy link
Owner

Summary

  • require shell-safe transport for multiline Markdown PR bodies in propose
  • explicitly forbid inline double-quoted multiline --body "..." usage
  • add safe create/edit examples and remediation for interpolation corruption

Changes

  • updated skills/propose/SKILL.md in the Create PR section with mandatory --body-file guidance
  • documented acceptable file creation patterns (direct file write, single-quoted heredoc)
  • expanded failure policy and corruption modes for shell interpolation corruption and recovery

Issue(s)

Closes #116

Test plan

  • inspect skills/propose/SKILL.md and verify:
    • shell-safe PR body transport is required
    • unsafe inline multiline double-quoted body usage is forbidden
    • create/edit safe examples are present
    • failure/corruption remediation references gh pr edit --body-file

@github-actions
Copy link

The diff only updates documentation in skills/propose/SKILL.md to require shell-safe PR body handling via --body-file. I did not find a correctness, reliability, or security regression introduced by these changes.

Raw outputs: codex-review.md, codex-review.jsonl

@pentaxis93 pentaxis93 merged commit 4fa3af6 into main Mar 10, 2026
1 check passed
@pentaxis93 pentaxis93 deleted the issue-116/fix-propose-require-shell-safe-pr-body branch March 10, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(propose): require shell-safe PR body handling to prevent backtick command substitution

1 participant