fix(cli): prune stale groundwork entries without lock file#114
Merged
pentaxis93 merged 1 commit intomainfrom Mar 10, 2026
Merged
Conversation
Detect groundwork-managed dependencies by repo+path when lock history is missing so stale skills/* entries are pruned during reconcile. Add no-lock regression tests, keep non-skills groundwork paths untouched, and align shipped-manifest order assertion with the current skill list. Refs #113
|
I did not identify any regressions or actionable defects in the diff against origin/main. The pruning logic change appears consistent with the stated intent and is covered by focused tests for both removal and preservation cases. Raw outputs: codex-review.md, codex-review.jsonl |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/*dependencies are removed even when no prior install lock existsskills/*) untouched without lock evidenceChanges
prune_stale_managed_dependenciesto treat an entry as managed when either lock history marks it managed or its dependency entry matchesgh = "pentaxis93/groundwork"pluspathunderskills/skills/*safety behaviorskills/systematic-debuggingIssue(s)
Closes #113
Test plan
cargo fmt --all -- --checkcargo test -p groundwork-cli prune_ -- --nocapturecargo test -p groundwork-cli update_prunes_stale_aliases_and_preserves_external -- --nocapturecargo test -p groundwork-cli