Skip to content

fix(cli): prune stale groundwork entries without lock file#114

Merged
pentaxis93 merged 1 commit intomainfrom
issue-113/fix-cli-reconcile-cannot-prune-stale-ent
Mar 10, 2026
Merged

fix(cli): prune stale groundwork entries without lock file#114
pentaxis93 merged 1 commit intomainfrom
issue-113/fix-cli-reconcile-cannot-prune-stale-ent

Conversation

@pentaxis93
Copy link
Owner

Summary

  • fix reconcile pruning so stale groundwork-managed skills/* dependencies are removed even when no prior install lock exists
  • preserve safety by continuing to keep non-groundwork dependencies (and groundwork entries outside skills/*) untouched without lock evidence
  • document the behavior change in the changelog

Changes

  • updated prune_stale_managed_dependencies to treat an entry as managed when either lock history marks it managed or its dependency entry matches gh = "pentaxis93/groundwork" plus path under skills/
  • added helper extraction for dependency fields from TOML dependency entries (inline table or table form)
  • added regression tests for no-lock stale skill pruning and non-skills/* safety behavior
  • synced the shipped-manifest order assertion in unit tests to include skills/systematic-debugging

Issue(s)

Closes #113

Test plan

  • cargo fmt --all -- --check
  • cargo test -p groundwork-cli prune_ -- --nocapture
  • cargo test -p groundwork-cli update_prunes_stale_aliases_and_preserves_external -- --nocapture
  • cargo test -p groundwork-cli

Detect groundwork-managed dependencies by repo+path when lock history is missing so stale skills/* entries are pruned during reconcile.

Add no-lock regression tests, keep non-skills groundwork paths untouched, and align shipped-manifest order assertion with the current skill list.

Refs #113
@github-actions
Copy link

I did not identify any regressions or actionable defects in the diff against origin/main. The pruning logic change appears consistent with the stated intent and is covered by focused tests for both removal and preservation cases.

Raw outputs: codex-review.md, codex-review.jsonl

@pentaxis93 pentaxis93 merged commit 1706404 into main Mar 10, 2026
1 check passed
@pentaxis93 pentaxis93 deleted the issue-113/fix-cli-reconcile-cannot-prune-stale-ent branch March 10, 2026 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(cli): reconcile cannot prune stale entries without a prior lock file

1 participant