Skip to content

fix: exclude non-regular files#776

Open
MqllR wants to merge 1 commit intopeak:masterfrom
MqllR:exclude-nonregular
Open

fix: exclude non-regular files#776
MqllR wants to merge 1 commit intopeak:masterfrom
MqllR:exclude-nonregular

Conversation

@MqllR
Copy link

@MqllR MqllR commented Dec 10, 2024

Close #775

Running the same command as describe in the issue:

go run . cp --exclude "*.ipc" /tmp/test/ s3://mybucket/
...
echo $?
0

@MqllR MqllR requested a review from a team as a code owner December 10, 2024 13:10
@MqllR MqllR requested review from igungor and ilkinulas and removed request for a team December 10, 2024 13:10
terryrankine added a commit to terryrankine/s5cmd that referenced this pull request Mar 18, 2026
Move the IsRegular() check after the exclude/include filter so that
non-regular files matching an exclude pattern are silently skipped
instead of producing spurious error messages. (peak#776)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Non regular files break cp even if they are excluded

1 participant