Merged
Conversation
* Also count analog trigger moves * Use playable game time instead of total game time (exclude ready-countdown) * Count analog stick moves whenever octant region changes * Source: https://github.com/project-slippi/slippi-js/blob/master/src/common/stats/inputs.ts#L66
Owner
|
@cbartsch sorry for the delay, I'm not as in the weeds of Melee as I used to be and I don't check this repo super often anymore. 😅 I scanned the changes and they look great, so assuming these changes are working for you, I'm just gonna rebase and merge as-is. Thanks a ton for your hard work! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
APM is calculated with the same formula as used by slippi-js and displayed in the official slippi launcher