Skip to content

Zhiyuan/slider#165

Open
zhiyuan-Z wants to merge 10 commits intopatricklindev:masterfrom
zhiyuan-Z:zhiyuan/slider
Open

Zhiyuan/slider#165
zhiyuan-Z wants to merge 10 commits intopatricklindev:masterfrom
zhiyuan-Z:zhiyuan/slider

Conversation

@zhiyuan-Z
Copy link
Copy Markdown

@zhiyuan-Z zhiyuan-Z commented May 23, 2023

Created a Slider with the following options based on the UI design:

  • Developers can choose the color of the slider component from variant choice by passing props.
  • Developers can choose the size of the component by providing props.
  • Developers can choose to have number marks on the slider track by providing value in props.
  • Developers can enable the slider component as a range slider from props. The range slider provides two knobs in order to take the input with a range of values.
  • Developers have the option to enable vertical slider from props
  • Developers can choose between discrete and continuous input mode for the slider from props
  • Developers can disable the input of the component from props.

@zhiyuan-Z zhiyuan-Z changed the base branch from production to master May 23, 2023 17:30
update storybook, add option for valueLabelDisplay, modify slider styles to use the original color system, update component export, fix lint issues
@zhiyuan-Z
Copy link
Copy Markdown
Author

Fixed issues mentioned in the code review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants