Change PER_GROUP_ONLY to PER_GROUP and update P4Runtime spec

[matthewtlam]

No description provided.

[jonathan-dilorenzo]

Why not GROUP_ACTION?

[jonathan-dilorenzo]

Or, it seems sorta nice that they are the same...

[jafingerhut]

Agreed that if @groupaction is the annotation, then GROUP_ACTION as the value of the enum would be nice to keep it similar to existing corresponding attribute/enum-value-names:

• @defaultonly -> DEFAULT_ONLY
• @tableonly -> TABLE_ONLY
• @groupaction -> GROUP_ACTION

[kheradmandG]

@matthewtlam could you update the description on why we are proposing this change?

This is to avoid the confusion regarding the expected semantics of the @groupaction annotation.
The @tableonly and @defaultonly are defined in a way that if an action has no annotation, that means that can be used for both table and default).
But our semantics of @groupaction (previously @pergrouponly) is inconsistent with that, in the sense that if the annotation is present on an action, it can be used as a group action (and nothing else) and if the annotation is absent, the action cannot be used as a group action.
The drop of "only" postfix in @groupaction is meant to indicate that there is a difference between how @groupaction annotation vs. @tableonly and @defaultonly annotations work.

Also it seems there is consensus on @groupaction / GROUP_ACTION. Could you please update the PR.

[kheradmandG]

@jafingerhut @jonathan-dilorenzo @smolkaj if everyone happy with the idea, let's get this in soon before we have developments with the older annotation.