refactor: remove Managed field from interface and route APIs#359
Merged
Conversation
Operations are idempotent and work on any resource regardless of whether osapi created it. The Managed boolean added noise without value — the osapi- file prefix already guards mutations. Also removes the UID >= 1000 filter from user ListUsers so all system accounts are returned. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #359 +/- ##
==========================================
- Coverage 99.92% 99.91% -0.01%
==========================================
Files 469 469
Lines 23814 23728 -86
==========================================
- Hits 23795 23708 -87
- Misses 11 12 +1
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Managedboolean field from interface and route list/get responses across all layers (provider, OpenAPI spec, handler, SDK, CLI, docs)scanManagedInterfaces()andloadManagedRoutes()functions that populated the fieldListUsersso all accounts are returnedOperations are idempotent and work on any resource regardless of whether osapi created it. The
osapi-file prefix already guards mutations — the Managed field added noise without value.Test plan
just go::unit)just go::vet)go build ./...)just generate)go generate ./pkg/sdk/client/gen/...)managedfield🤖 Generated with Claude Code