Conversation
Creates comprehensive guide covering build commands, architecture overview, and development patterns for the Nebula Kotlin DSL project. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
… stack if present and the same. Improves experience when running with a cluster of orbital servers
✅ Deploy Preview for orbital-nebula canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses stack duplication issues in clustered environments by implementing source-based deduplication. When multiple submissions of the same stack are received, the system now compares the source content and reuses existing stacks instead of duplicating them.
Key changes:
- Introduces
NebulaStackWithSourcewrapper to track stack source content - Updates stack submission logic to compare source strings for deduplication
- Modifies API endpoints and internal methods to use the new wrapper type
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| NebulaStack.kt | Adds NebulaStackWithSource data class to wrap stacks with their source content |
| NebulaScriptExecutor.kt | Adds toStackWithSource() method and deprecates toStack() |
| StackRunner.kt | Updates submission logic to compare source content and avoid duplicates |
| NebulaServer.kt | Modifies HTTP endpoints to use new stack-with-source methods |
| NebulaCli.kt | Updates CLI to create stacks with source content |
| CLAUDE.md | Adds new documentation file for development guidance |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running in a cluster, we see the stack get duplicated when receiving multiple submissions.
This attempts to address this, by only updating the stack if the submitted stack is different