feat(rpc-v2): include merkle root atomically in proof response#71
Merged
feat(rpc-v2): include merkle root atomically in proof response#71
Conversation
Add `root` field to `MerkleProofResponse` and introduce
`generate_proof_with_root` / `generate_proof_by_commitment_with_root`
service methods that read both the Merkle root and the sibling path
under the same `best_block` reference.
This eliminates the previous race condition where the root and path
could be fetched from different chain heads, causing proof verification
failures due to mismatched state.
The `privacy_getMerkleProofByCommitment` RPC endpoint now returns
`{ root, path, leaf_index, tree_depth }` in a single atomic call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
rootfield toMerkleProofResponseand introducegenerate_proof_with_root/generate_proof_by_commitment_with_rootservice methods that read both the Merkle root and the sibling path under the samebest_blockreference.This eliminates the previous race condition where the root and path could be fetched from different chain heads, causing proof verification failures due to mismatched state.
The
privacy_getMerkleProofByCommitmentRPC endpoint now returns{ root, path, leaf_index, tree_depth }in a single atomic call.