-
Notifications
You must be signed in to change notification settings - Fork 36
[FSSDK-12276] update: replace flake8 with ruff #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-12276] update: replace flake8 with ruff #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Replaces Flake8 with Ruff as the project’s Python linter by adding Ruff configuration, updating developer docs, and switching CI to run ruff check.
Changes:
- Add
ruff.tomlwith Flake8-equivalent rule selection (E/W/F) and project excludes. - Swap Flake8 for Ruff in test requirements and GitHub Actions lint job.
- Update contributor documentation to reference Ruff; remove legacy
.flake8.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
ruff.toml |
Introduces Ruff config (line length, excludes, selected rule families, per-file ignores). |
requirements/test.txt |
Replaces flake8 dependency with ruff. |
CONTRIBUTING.md |
Updates contributor workflow and style notes to use Ruff. |
.github/workflows/python.yml |
Updates CI lint job to install/run Ruff instead of Flake8. |
.flake8 |
Removes obsolete Flake8 configuration file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Mat001
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Make sure that no errors in PR checks.
Summary
The change simplifies the linting setup, improves performance, and reduces dependency overhead while maintaining equivalent linting coverage. Linting errors that do not break code logic can be auto fixed using
ruff check . --fixTest plan
ruff check .locallyIssues
FSSDK-12276