patchkernel: add the concept of "adaption mode"#371
Merged
andrea-iob merged 5 commits intomasterfrom May 20, 2024
Merged
Conversation
andrea-iob
force-pushed
the
patchkernel.define.adaption.mode
branch
2 times, most recently
from
fd1cd54 to
b29597f
Compare
Member
There was a problem hiding this comment.
Why PARTITIONING_DISABLED?
andrea-iob
force-pushed
the
patchkernel.define.adaption.mode
branch
from
b29597f to
989a456
Compare
andrea-iob
force-pushed
the
patchkernel.define.adaption.mode
branch
from
989a456 to
4dab160
Compare
Member
Author
|
I've removed all the changes not directly related to this pull request. |
marcocisternino
approved these changes
May 16, 2024
Member
marcocisternino
left a comment
marcocisternino
left a comment
There was a problem hiding this comment.
check code and tested in application using voloctree.
Tests using manual adapted volunstructured or surfunstructured would test the branch better than I did.
Adaption mode tells if the patch can be adapted and which strategies can be used to adapt the patch. The following adaption modes are supported: - disabled, no adaption can be performed; - automatic, adaption is performed specifying which cells should be refined/coarsen and then the patch will perform all the alterations needed to fulfill the adaption requests; - manual, this mode allows to use low level function to add and delete individual cells and vertices. It's up to the user to guarantee the consistency of the patch.
Partitioning mode tells if the patch can be partitioned across the processes. The following partitioning modes are supported: - disabled, no partitioning can be performed; - enabled, the patch can be partitioned across the processes.
andrea-iob
force-pushed
the
patchkernel.define.adaption.mode
branch
from
4dab160 to
eba83ac
Compare
edoardolombardi
approved these changes
May 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adaption mode tells if the patch can be adapted and which strategies can be used to adapt the patch.
The following adaption modes are supported:
Adaption mode replaces the concept of "expert mode". The functions "isExpert" and "setExpert" are now deprecated.
Depends on #370.