fix(prefs): remove obsolete Firefox preferences#1140
Draft
Conversation
vringar
force-pushed
the
fix/obsolete-firefox-prefs
branch
from
aa66982 to
401b02f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
- Coverage 56.75% 56.36% -0.40%
==========================================
Files 40 40
Lines 3908 3882 -26
==========================================
- Hits 2218 2188 -30
- Misses 1690 1694 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…x.py
Remove preferences that no longer exist in modern Firefox (v147+),
verified against mozilla-central via searchfox.org.
Removed preferences (no longer in Firefox source):
- browser.slowStartup.{notificationDisabled,maxSamples,samples}
- extensions.checkCompatibility.nightly
- dom.flyweb.enabled (FlyWeb feature removed)
- dom.ipc.plugins.{reportCrashURL,flash.subprocess.crashreporter.enabled}
(NPAPI plugin support removed)
- browser.selfsupport.url
- browser.urlbar.userMadeSearchSuggestionsChoice
- browser.casting.enabled
- browser.search.countryCode
- browser.search.geoSpecificDefaults{,.url}
- app.update.enabled
- lightweightThemes.update.enabled (Personas/lightweight themes removed)
- experiments.{enabled,manifest.uri,supported,activeExperiment}
- network.allow-experiments
- browser.newtabpage.{directory.ping,directory.source,enhanced,introShown}
- browser.aboutHomeSnippets.updateUrl
- extensions.shield-recipe-client.enabled (replaced by Normandy)
Also fixed:
- browser.safebrowsing.phising.enabled -> phishing.enabled (typo fix)
- Minor comment improvements
Closes #1060
vringar
force-pushed
the
fix/obsolete-firefox-prefs
branch
from
401b02f to
adc2fca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
browser.safebrowsing.phising.enabled->browser.safebrowsing.phishing.enabledCloses #1060
Changes
openwpm/deploy_browsers/configure_firefox.py: Remove obsolete prefs, fix typo, update commentsRemoved preferences (categories)
browser.slowStartup.*,extensions.checkCompatibility.nightly,dom.flyweb.enableddom.ipc.plugins.*browser.selfsupport.urlbrowser.urlbar.userMadeSearchSuggestionsChoice,browser.casting.enabled,browser.search.countryCode,browser.search.geoSpecificDefaults*app.update.enabled,lightweightThemes.update.enabledexperiments.*,network.allow-experimentsbrowser.newtabpage.directory.*,browser.newtabpage.enhanced,browser.newtabpage.introShown,browser.aboutHomeSnippets.updateUrlextensions.shield-recipe-client.enabledTest plan