fix: don't count DNS errors against consecutive failure limit#1139
Draft
fix: don't count DNS errors against consecutive failure limit#1139
Conversation
e3f6f4c to
e543f83
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
==========================================
- Coverage 56.75% 56.74% -0.02%
==========================================
Files 40 40
Lines 3908 3909 +1
==========================================
Hits 2218 2218
- Misses 1690 1691 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When crawling large domain lists (e.g. Tranco top 100k), many domains cannot be resolved via DNS. These dnsNotFound neterrors are expected and do not indicate a browser or instrumentation failure. Previously they were counted against MAX_CONSECUTIVE_FAILURES, eventually crashing the crawl. Skip the failure counter increment and browser restart for dnsNotFound neterrors so that DNS resolution failures no longer crash large crawls. Fixes #1116
e543f83 to
79ce7fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dnsNotFound) are expected when crawling large domain lists and don't indicate browser/instrumentation failurecrawl_historywith statusneterrorCloses #1116
Changes
openwpm/browser_manager.py: Addis_dns_errorcheck before incrementingfailure_countand triggering browser restartTest plan
test/test_webdriver_utils.py::test_parse_neterror_integrationto verify DNS errors are still recorded correctly