fix(cleanup): remove XPI temp files from /tmp on shutdown#1138
Closed
fix(cleanup): remove XPI temp files from /tmp on shutdown#1138
Conversation
… shutdown Track temporary XPI files created by geckodriver during install_addon() and clean them up on browser shutdown/restart. Also moves tempdir cleanup outside the success block so it runs even on failed browser launches. Closes #1090
8783515 to
0ee25b7
Compare
Contributor
Author
|
Closing in favor of #1104 — the racy tracking approach doesn't align with OpenWPM's robustness-first philosophy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
install_addon()and clean them up on browser shutdown/restartextend()instead of=when collecting tmp_files to avoid leaking files from retried spawn attemptsCloses #1090
Changes
openwpm/deploy_browsers/deploy_firefox.py: Detect new XPI files via glob before/afterinstall_addon(), report them via status queueopenwpm/browser_manager.py: Tracktmp_filesonBrowserManagerHandle, clean up inshutdown_browser()andrestart_browser_manager()Test plan