Temp plugin PR for discussion#2273
Conversation
# Conflicts: # make/common/Modules.gmk
|
👋 Welcome back dbeaumont! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
|
||
| ################################################################################ | ||
|
|
||
| $(eval $(call SetupJavaCompilation, BUILD_VALUETYPE_GENSRC, \ |
There was a problem hiding this comment.
I don't know if BUILD_VALUETYPE_GENSRC here has to match the one in ToolsJdk.gmk, but I assume so for now.
Might even be worth a plugin macro/rule since there are now 2 cases and generating the service provider stuff could be made common.
There was a problem hiding this comment.
If the plugin works, I can delete this (but this is the working annotation processor for reference for now).
| List<JCClassDecl> classes = new ArrayList<>(); | ||
| new TreeScanner() { | ||
| @Override | ||
| public void visitClassDef(JCClassDecl cls) { |
There was a problem hiding this comment.
Even if the test for "having an annotation" isn't working, the code should just result in nothing happening, but that's not the case, it just fails (without any useful output).
1 participant
Temp plugin PR for discussion
Progress
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2273/head:pull/2273$ git checkout pull/2273Update a local copy of the PR:
$ git checkout pull/2273$ git pull https://git.openjdk.org/valhalla.git pull/2273/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2273View PR using the GUI difftool:
$ git pr show -t 2273Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2273.diff