Skip to content

8381004: [lworld] FieldLayoutInfo use an aggregate for nonoop_acmp_map entries#2266

Open
walulyai wants to merge 4 commits intoopenjdk:lworldfrom
walulyai:AddAcmpMapSegment
Open

8381004: [lworld] FieldLayoutInfo use an aggregate for nonoop_acmp_map entries#2266
walulyai wants to merge 4 commits intoopenjdk:lworldfrom
walulyai:AddAcmpMapSegment

Conversation

@walulyai
Copy link
Copy Markdown
Member

@walulyai walulyai commented Mar 26, 2026

Hi,

Please review this patch to replace Pair with a simple aggregate for entries in _nonoop_acmp_map to improve code readability.

Testing: GHA


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8381004: [lworld] FieldLayoutInfo use an aggregate for nonoop_acmp_map entries (Enhancement - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2266/head:pull/2266
$ git checkout pull/2266

Update a local copy of the PR:
$ git checkout pull/2266
$ git pull https://git.openjdk.org/valhalla.git pull/2266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2266

View PR using the GUI difftool:
$ git pr show -t 2266

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2266.diff

Using Webrev

Link to Webrev Comment

}
is_null_restricted = true;
}
parsed_annotations.set_field_annotations(nullptr);
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already do this reset on L1475

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 26, 2026

👋 Welcome back iwalulya! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 26, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@walulyai walulyai marked this pull request as ready for review March 26, 2026 14:28
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 26, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 26, 2026

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant