Skip to content

8293280: [lworld] IdentityHashmap spec when key is a Value class#2251

Open
RogerRiggs wants to merge 1 commit intoopenjdk:lworldfrom
RogerRiggs:8378286-identity-hashmap-value-classes
Open

8293280: [lworld] IdentityHashmap spec when key is a Value class#2251
RogerRiggs wants to merge 1 commit intoopenjdk:lworldfrom
RogerRiggs:8378286-identity-hashmap-value-classes

Conversation

@RogerRiggs
Copy link
Copy Markdown
Collaborator

@RogerRiggs RogerRiggs commented Mar 23, 2026

In the IdentityHashMap class javadoc elaborate the meaning and use of == sameness meaning indistinguishable.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JDK-8293280: [lworld] IdentityHashmap spec when key is a Value class (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2251/head:pull/2251
$ git checkout pull/2251

Update a local copy of the PR:
$ git checkout pull/2251
$ git pull https://git.openjdk.org/valhalla.git pull/2251/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2251

View PR using the GUI difftool:
$ git pr show -t 2251

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2251.diff

Using Webrev

Link to Webrev Comment

Elaborate the meaning and use of `==` sameness meaning indistingusable.
@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 23, 2026

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 23, 2026

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 23, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 23, 2026

Webrevs

@RogerRiggs
Copy link
Copy Markdown
Collaborator Author

@dansmithcode Please review, Is there more to say here? tnx

/**
* This class implements the {@code Map} interface with a hash table, using
* `==` in place of object-equality when comparing keys (and values).
* `==` in place of `.equals()` equality when comparing keys (and values).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML render has no special treatment of backtick chars. Only markdown converts them to code blocks. See the current rendering at https://download.java.net/java/early_access/valhalla/27/docs/api/java.base/java/util/IdentityHashMap.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants