8293280: [lworld] IdentityHashmap spec when key is a Value class#2251
Open
RogerRiggs wants to merge 1 commit intoopenjdk:lworldfrom
Open
8293280: [lworld] IdentityHashmap spec when key is a Value class#2251RogerRiggs wants to merge 1 commit intoopenjdk:lworldfrom
RogerRiggs wants to merge 1 commit intoopenjdk:lworldfrom
Conversation
Elaborate the meaning and use of `==` sameness meaning indistingusable.
|
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
Collaborator
Author
|
@dansmithcode Please review, Is there more to say here? tnx |
liach
reviewed
Mar 26, 2026
| /** | ||
| * This class implements the {@code Map} interface with a hash table, using | ||
| * `==` in place of object-equality when comparing keys (and values). | ||
| * `==` in place of `.equals()` equality when comparing keys (and values). |
Member
There was a problem hiding this comment.
HTML render has no special treatment of backtick chars. Only markdown converts them to code blocks. See the current rendering at https://download.java.net/java/early_access/valhalla/27/docs/api/java.base/java/util/IdentityHashMap.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the IdentityHashMap class javadoc elaborate the meaning and use of
==sameness meaning indistinguishable.Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2251/head:pull/2251$ git checkout pull/2251Update a local copy of the PR:
$ git checkout pull/2251$ git pull https://git.openjdk.org/valhalla.git pull/2251/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2251View PR using the GUI difftool:
$ git pr show -t 2251Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2251.diff
Using Webrev
Link to Webrev Comment