Skip to content

[bworld-apis] Adding more bangs to collections#2112

Open
vicente-romero-oracle wants to merge 18 commits intoopenjdk:bworld-apisfrom
vicente-romero-oracle:adding.more.bangs.to.collections
Open

[bworld-apis] Adding more bangs to collections#2112
vicente-romero-oracle wants to merge 18 commits intoopenjdk:bworld-apisfrom
vicente-romero-oracle:adding.more.bangs.to.collections

Conversation

@vicente-romero-oracle
Copy link
Copy Markdown
Contributor

@vicente-romero-oracle vicente-romero-oracle commented Feb 14, 2026

adding more bangs to collection apis


Progress

  • Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/2112/head:pull/2112
$ git checkout pull/2112

Update a local copy of the PR:
$ git checkout pull/2112
$ git pull https://git.openjdk.org/valhalla.git pull/2112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2112

View PR using the GUI difftool:
$ git pr show -t 2112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/2112.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Feb 14, 2026

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into bworld-apis will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Feb 14, 2026

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

[bworld-apis] Adding more bangs to collections

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the bworld-apis branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the bworld-apis branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Feb 14, 2026

*/
public boolean removeIf(Predicate<? super E> filter) {
public boolean removeIf(Predicate<? super E>! filter) {
Objects.requireNonNull(filter);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Objects.requireNonNull(filter);

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 19, 2026

@vicente-romero-oracle This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant