Merged
Conversation
Member
irtazaakram
commented
Nov 3, 2025
irtazaakram
commented
- Resolves Drop Python 3.8 & Add Support for Python 3.12 #191
feanil
reviewed
Nov 6, 2025
Contributor
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Generally looks good, one piece of missing documentation. Also, I've added the maintainer in case they want to do an extra pass review.
| RUN add-apt-repository -y ppa:deadsnakes/ppa && apt-get update && apt-get upgrade -y | ||
| RUN apt-get install -y vim python${python_version} python${python_version}-dev python${python_version}-distutils | ||
| RUN apt-get install -y vim python${python_version} python${python_version}-dev python${python_version}-venv || \ | ||
| apt-get install -y vim python${python_version} python${python_version}-dev python3-distutils |
Contributor
There was a problem hiding this comment.
Is this because 3.12 doesn't have a -venv package? Can you add a comment in this file explaining why this || install is happening?
Member
Author
There was a problem hiding this comment.
python 3.12 doesn't have distutils package. I've added comments for these changes.
feanil
approved these changes
Nov 7, 2025
Contributor
|
@MoisesGSalas do you want to review this? I think it's good to go. |
MoisesGSalas
approved these changes
Nov 7, 2025
Contributor
|
All good IMO, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.