fix: taskkill on Windows Git Bash (MSYS path + non-English locale) (#219)#220
fix: taskkill on Windows Git Bash (MSYS path + non-English locale) (#219)#220D2758695161 wants to merge 1 commit intoopenai:mainfrom
Conversation
Fixes two bugs in terminateProcessTree(): 1. MSYS argument path conversion: Add MSYS_NO_PATHCONV=1 and MSYS2_ARG_CONV_EXCL="*" to disable MSYS path rewriting 2. Non-English locale detection: Accept exit code 128 as "already dead" Fixes openai#219
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 20ac5c627e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1,22 +0,0 @@ | |||
| { | |||
There was a problem hiding this comment.
This patch deletes package.json and effectively removes the rest of the plugin repository (workflows, commands, tests, and supporting scripts), leaving only plugins/codex/scripts/lib/process.mjs in the commit tree. That makes the project non-buildable and non-testable, which is a release-blocking regression unrelated to the stated taskkill fix.
Useful? React with 👍 / 👎.
1 participant
Fix: taskkill Cancellation on Windows Git Bash (#219)
Problem
/codex:cancelfails to terminate background jobs on Windows Git Bash (MSYS2) due to two bugs:/PID,/T,/Farguments into Windows pathsSolution
MSYS_NO_PATHCONV=1andMSYS2_ARG_CONV_EXCL="*"to disable MSYS argument path rewritingresult.status === 128as a locale-independent "already dead" indicatorCloses #219