pprof: add scope attributes for sample type ordering and defaults #3368
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change adds two new pprof-specific attributes to support the lossless conversion between pprof and OTel profile formats. These attributes address the handling of pprof's `default_sample_type` and the preservation of the original sample type order. New attributes: - `pprof.scope.default_sample_type`: Records the default_sample_type from the original pprof profile. - `pprof.scope.sample_type_order`: Records the indices of the sample types in the original profile to allow exact reconstruction of the pprof sample type array. The new attributes use the `pprof.scope.*` naming to clearly indicate they apply to the `ScopeProfiles` level. This is similar naming-wise with the existing `pprof.mapping.*` and `pprof.location.*` attributes while avoiding ambiguity with `pprof.profile.*` (which applies to individual Profile messages). For more details see the original [design notes](https://docs.google.com/document/d/1CF_xg0AFBGyFhkL1hdSSaOXW4pLApg39PwYdcM0xVW8/edit?tab=t.0).
Member
Author
|
@open-telemetry/profiling-approvers @florianl FYI |
joaopgrassi
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
joaopgrassi
approved these changes
Feb 2, 2026
christos68k
reviewed
Feb 5, 2026
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
Co-authored-by: Christos Kalkanis <christos.kalkanis@elastic.co>
christos68k
approved these changes
Feb 6, 2026
github-project-automation
bot
moved this from Awaiting codeowners approval
to Needs More Approval
in Semantic Conventions Triage
lmolkova
moved this from Needs More Approval
to Ready to be Merged
in Semantic Conventions Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The change adds two new pprof-specific attributes to support the lossless conversion between pprof and OTel profile formats. These attributes address the handling of pprof's
default_sample_typeand the preservation of the original sample type order.New attributes:
pprof.scope.default_sample_type: Records the default_sample_type from the original pprof profile.pprof.scope.sample_type_order: Records the indices of the sample types in the original profile to allow exact reconstruction of the pprof sample type array.The new attributes use the
pprof.scope.*naming to clearly indicate they apply to theScopeProfileslevel. This is similar naming-wise with the existingpprof.mapping.*andpprof.location.*attributes while avoiding ambiguity withpprof.profile.*(which applies to individual Profile messages).For more details see the original design notes.