Skip to content

Fix flaky test_supervisor_stale_uuid_does_not_panic test #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jordanschalm wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix flaky test_supervisor_stale_uuid_does_not_panic test #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions cadence/tests/paid_auto_balance_test.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,33 +321,43 @@ access(all) fun test_supervisor_stale_uuid_does_not_panic() {
Test.assertEqual(1, createdEvts.length)
let created = createdEvts[0] as! FlowALPRebalancerv1.CreatedRebalancer

// Flush the initial scheduled tick (created at timestamp+1s during setup) so it doesn't
// fire during the intermediate block commits below. Without this, the supervisor may
// execute while the rebalancer still exists, consuming the cron boundary and preventing
// a later tick from seeing the stale UUID.
Test.moveTime(by: 5.0)
Test.commitBlock()

let baselineExecuted = Test.eventsOfType(Type<FlowALPSupervisorv1.Executed>()).length

// Register the UUID with the Supervisor so it will call fixReschedule on it each tick.
addPaidRebalancerToSupervisor(signer: userAccount, positionID: created.positionID, supervisorStoragePath: supervisorStoragePath)

// Delete the paid rebalancer WITHOUT removing its UUID from the Supervisor — this leaves a
// stale UUID in the Supervisor's paidRebalancers set, simulating the FLO-27 bug scenario.
deletePaidRebalancer(signer: userAccount, paidRebalancerStoragePath: paidRebalancerStoragePath)

// Advance time to trigger the Supervisor's scheduled tick.
Test.moveTime(by: 60.0 * 60.0)
// Advance by just over 1 hour to guarantee crossing a cron boundary ("0 * * * *").
Test.moveTime(by: 60.0 * 60.0 + 1.0)
Test.commitBlock()

// The Supervisor must have executed without panicking. If fixReschedule force-unwrapped
// the missing rebalancer the entire transaction would revert and Executed would not be emitted.
let executedEvts = Test.eventsOfType(Type<FlowALPSupervisorv1.Executed>())
Test.assert(executedEvts.length >= 1, message: "Supervisor should have executed at least 1 time")
Test.assert(executedEvts.length > baselineExecuted, message: "Supervisor should have executed after time advance")

// The stale UUID must have been pruned from the Supervisor's set.
let removedEvts = Test.eventsOfType(Type<FlowALPSupervisorv1.RemovedPaidRebalancer>())
Test.assertEqual(1, removedEvts.length)
let removed = removedEvts[0] as! FlowALPSupervisorv1.RemovedPaidRebalancer
Test.assert(removedEvts.length >= 1, message: "Stale UUID should have been pruned")
let removed = removedEvts[removedEvts.length - 1] as! FlowALPSupervisorv1.RemovedPaidRebalancer
Test.assertEqual(created.positionID, removed.positionID)

// A second tick should not emit another RemovedPaidRebalancer — the UUID was already cleaned up.
Test.moveTime(by: 60.0 * 60.0)
let baselineRemoved = removedEvts.length
Test.moveTime(by: 60.0 * 60.0 + 1.0)
Test.commitBlock()
let removedEvts2 = Test.eventsOfType(Type<FlowALPSupervisorv1.RemovedPaidRebalancer>())
Test.assertEqual(1, removedEvts2.length)
Test.assertEqual(baselineRemoved, removedEvts2.length)
}

access(all) fun test_supervisor() {
Expand Down
Loading