feature: Add support for sysman python bindings#420
feature: Add support for sysman python bindings#420shubskmr wants to merge 14 commits intooneapi-src:masterfrom
Conversation
Related-To: NEO-NEO-17257 Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Related-To: NEO-NEO-17257 Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Related-To: NEO-NEO-17257 Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Related-To: NEO-NEO-17257 Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Related-To: NEO-NEO-17257 Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Related-To: NEO-NEO-17257 Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Signed-off-by: shubham kumar <shubham.kumar@intel.com>
|
@rwmcguir I have added the workflow for bindings ULT coverage along with the .toml file for package creation. Can you please take a look and review them? |
| @@ -0,0 +1,7 @@ | |||
| """ | |||
There was a problem hiding this comment.
Silly, but this needs Copyright / License as well.
| @@ -0,0 +1,53 @@ | |||
| name: Python Bindings - Security Scan | |||
There was a problem hiding this comment.
If we have the ability to Copyright/License this file, please do if .yml supports comments
| @@ -0,0 +1,300 @@ | |||
| name: Python Bindings - Unit Tests & Coverage | |||
There was a problem hiding this comment.
If we have the ability to Copyright/License this file, please do if .yml supports comments
| @@ -0,0 +1,105 @@ | |||
| ## | |||
| # Copyright (C) 2025 Intel Corporation | |||
| @@ -0,0 +1,1030 @@ | |||
| #!/usr/bin/env python3 | |||
| ## | |||
| # Copyright (C) 2025 Intel Corporation | |||
There was a problem hiding this comment.
Copyrights in all files could be updated
|
|
||
| class _PrintableStructure(Structure): | ||
| """ | ||
| Abstract class that produces nicer __str__ output than ctypes.Structure. |
There was a problem hiding this comment.
yes this good to have since python has concept of doc-strings and having explanations for classes/methods is encouraged.
| ("timerResolution", c_uint64), | ||
| ("timestampValidBits", c_uint32), | ||
| ("kernelTimestampValidBits", c_uint32), | ||
| ("uuid", ze_device_uuid_t), |
There was a problem hiding this comment.
Is this ze_device_uuid_t or zes counter part ?
There was a problem hiding this comment.
this is the core structure ze_device_properties_t, we need this as this is a member of zes_device_properties_t
| ("type", ze_device_type_t), | ||
| ("vendorId", c_uint32), | ||
| ("deviceId", c_uint32), | ||
| ("flags", ze_device_property_flags_t), |
There was a problem hiding this comment.
yes its present just below this structure definition zes_device_properties_t
Signed-off-by: shubham kumar <shubham.kumar@intel.com>
Related-To: NEO-17257 Signed-off-by: shubham kumar <shubham.kumar@intel.com>
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pytest pytest-cov pytest-html pytest-xdist | ||
| pip install coverage[toml] |
There was a problem hiding this comment.
Coverage uses Apache license right ?
Is it ok to use @rwmcguir .
Please confirm
3 participants
Related-To: NEO-NEO-17257
Signed-off-by: shubham kumar shubham.kumar@intel.com