Fix PWA install prompt missing in Chromium browsers#676
Merged
Conversation
The manifest icon paths pointed to root (e.g. /android-chrome-192x192.png) instead of /favicons/android-chrome-192x192.png. Root-level requests hit the Firebase SPA rewrite and returned HTML, so Chromium saw invalid icons and suppressed the install prompt. Remove static manifest.json files whose icon paths were inherited verbatim by generateManifest(). The auto-discovery path already produces correct /favicons/ prefixed paths for all themes. Also remove unused site.webmanifest files from theme directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
srcpaths pointed to root (/android-chrome-192x192.png) instead of/favicons/android-chrome-192x192.png. Root-level requests hit the Firebase SPA rewrite and returned HTML, so Chromium saw invalid icons and suppressed the install prompt.manifest.jsonfiles fromtheme/lszt/andtheme/lszk/whose broken icon paths were inherited verbatim bygenerateManifest(). The auto-discovery code path already produces correct/favicons/-prefixed paths.site.webmanifestfiles from all other theme directories (already excluded from build bycopyFavicons()).Test plan
npm run build --project=lszt), verifybuild/favicons/manifest.jsonicon paths start with/favicons/