Build using custom/local Docker registry#65
Draft
dra27 wants to merge 1 commit intoocurrent:masterfrom
Draft
Conversation
Contributor
|
Sounds useful! The |
talex5
reviewed
Oct 26, 2020
dda3a41 to
611f1a1
Compare
Allows the entire process to run without needing to push to Docker hub (which allows the process to run without needing any real secrets)
611f1a1 to
eb6f68b
Compare
Contributor
Author
|
This is now just the local registries stuff - although I think it's still a bit related to ocurrent/ocluster#86 (that is, the message about not pushing to the hub I don't think is true - it will now try but fail) |
64dfa12 to
5b6d232
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft (at least) until:
The tweak to
opam initcan obviously be spun out to another PR, as can the--submission-servicechange.I've started updating
README.mdwith instructions on running a local scheduler and worker and also a local development docker registry, so on my machine I can saydocker run --rm -it localhost:5000/ocurrent/opam. This could be updated to do similarly for the reads, and make it entirely free of Docker Hub... but the main reason I hacked this in originally was because I being lazy about having to set-up the secrets on my Docker ID 🙂