fix: fix issues regarding call of super.dispose + errors in documentation#72
Merged
fix: fix issues regarding call of super.dispose + errors in documentation#72
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the ordering of super.dispose() calls in the MVVM layer to ensure cleanup happens before the base dispose, and applies a broad set of spelling/wording corrections across docs, CI templates, and logging/mocking comments.
Changes:
- Move
super.dispose()to the end ofdispose()implementations in MVVMViewModelandMvvmWidgetstate. - Fix/standardize wording and spelling in app code comments/log messages, docs, and pipeline templates.
- Update CLI changelog with a new patch release entry.
Reviewed changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cli/CHANGELOG.md | Adds 0.26.2 entry + minor changelog formatting/spelling fixes. |
| src/app/lib/presentation/mvvm/view_model.dart | Ensures subscriptions are cancelled before calling super.dispose(). |
| src/app/lib/presentation/mvvm/mvvm_widget.dart | Ensures widget cleans up ViewModel/listener before calling super.dispose(). |
| src/app/lib/presentation/diagnostic/mocking_configuration_widget.dart | Fixes widget doc comment to reference mocking (not logging). |
| src/app/lib/presentation/diagnostic/expanded_diagnostic_page.dart | Fixes diagnostic overlay doc comment wording. |
| src/app/lib/presentation/diagnostic/environment_picker_widget.dart | Fixes spelling in local variable name (selectedEnvironment). |
| src/app/lib/main.dart | Fixes grammar in initialization log messages. |
| src/app/lib/business/mocking/mocking_manager.dart | Corrects doc comments to refer to mocking (not logging). |
| src/app/lib/business/logger/logger_manager.dart | Fixes spelling/grammar + renames helper to _checkIfChangesHaveBeenMade(). |
| src/app/lib/access/logger/logger_repository.dart | Fixes key naming (_fileLoggingKey) + corrects comment. |
| src/app/lib/access/logger/custom_file_output.dart | Fixes comment typo (“from from”). |
| src/app/lib/access/firebase/firebase_repository.dart | Fixes log message capitalization + spelling (“through”). |
| src/app/lib/access/diagnostics/diagnostics_repository.dart | Fixes repository name in comment. |
| doc/Testing.md | Fixes multiple typos/wording in testing documentation. |
| doc/SecurityScan.md | Fixes duplicated word in heading. |
| doc/Logging.md | Fixes links/text (but still contains broken links — see comments). |
| doc/ForcedUpdate.md | Fixes service name casing (but method name is now inconsistent with code — see comments). |
| doc/Environment.md | Fixes spelling (“overridden”). |
| doc/Diagnostics.md | Fixes wording (“remainder”, singular “widget”). |
| doc/AzurePipelines.md | Fixes spelling (“straightforward”). |
| doc/Architecture.md | Fixes grammar in architecture notes. |
| build/variables.yml | Fixes typos in pipeline variable comments (“Corresponds”, “artifacts”, “separate”). |
| build/templates/validate-commits.yaml | Fixes error message grammar (“do not follow”). |
| build/templates/replace-firebase-config.yml | Fixes task display names to match downloaded secure files. |
| CONTRIBUTING.md | Fixes broken markdown and adds direct link to GitHub Issues. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Soap-141
approved these changes
Mar 4, 2026
Contributor
Soap-141
left a comment
There was a problem hiding this comment.
Some comments by Copilot are relevant, however, it looks good.
6b62a6e to
1c485cc
Compare
1c485cc to
fcd437c
Compare
jeanplevesque
approved these changes
Mar 5, 2026
126f11c to
db4656e
Compare
db4656e to
b4893f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
Description
fix issues regarding call of super.dispose
fix errors in documentation and spelling errors in code
Impact on version
PR Checklist
Always applicable
No matter your changes, these checks always apply.
README.mdandsrc/cli/CLI.mdif you made changes to templating.AzurePipelines.mdandsrc/app/README.mdif you made changes to pipelines.Diagnostics.mdif you made changes to diagnostic tools.Architecture.mdand its diagrams if you made architecture decisions or if you introduced new recipes.doc/folder.Contextual
Based on your changes these checks may not apply.
Other information
Internal Issue (If applicable):