fix(assistant): use internal fetch for MCP on workers#1309
Open
onmax wants to merge 1 commit intonuxt-content:mainfrom
Open
fix(assistant): use internal fetch for MCP on workers#1309onmax wants to merge 1 commit intonuxt-content:mainfrom
onmax wants to merge 1 commit intonuxt-content:mainfrom
Conversation
|
@onmax is attempting to deploy a commit to the NuxtLabs Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1304.
related vercel/ai#13449
Summary
The assistant handler creates an MCP client that fetches the same worker's
/mcpendpoint. On Cloudflare Workers this triggers error 1042 (self-fetch recursion protection), so/__docus__/assistantalways returns 500.The fix creates a custom MCP transport that uses
event.fetch(Nitro'slocalFetch) instead ofevent.$fetch(which maps toglobalThis.$fetch→ globalfetch()→ CF self-fetch error). On CF Workers:event.fetch→useNitroApp().localFetch(internal routing, no HTTP)event.$fetch→globalThis.$fetch→fetch()(external HTTP, blocked by CF)External MCP servers and local dev still use the standard HTTP transport.
Reproduction
Verify
Bug worker:
Fixed worker:
Local verification: