feat: look for config file in .config subdirectory#669
Open
brianmcgee wants to merge 1 commit intomainfrom
Open
feat: look for config file in .config subdirectory#669brianmcgee wants to merge 1 commit intomainfrom
.config subdirectory#669brianmcgee wants to merge 1 commit intomainfrom
Conversation
Closes #668 Signed-off-by: Brian McGee <brian@bmcgee.ie>
jfly
reviewed
Feb 27, 2026
| cfg.TreeRoot = filepath.Dir(v.ConfigFileUsed()) | ||
|
|
||
| // if the config file resides within a `.config` folder, we use its parent folder as the tree root | ||
| if strings.HasSuffix(cfg.TreeRoot, ".config") { |
Collaborator
There was a problem hiding this comment.
Would this do the right thing if I had a project named foo.config with a treefmt.toml in it? If I'm reading this correctly, I worry we'd set cfg.TreeRoot to the parent of the foo.config directory.
IMO, this logic feels is too far removed from the filenames logic in root.go. I believe we have the correct directory returned to us by FindUp, and we just discard it:
Line 144 in 873c6d5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #668