Merged
Conversation
roman-khimov
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3906 +/- ##
==========================================
- Coverage 26.78% 26.77% -0.01%
==========================================
Files 677 677
Lines 44606 44608 +2
==========================================
Hits 11946 11946
Misses 31551 31551
- Partials 1109 1111 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bad things can happen with the same parent/child IDs or other ID cycles:
runtime: goroutine stack exceeds 1000000000-byte limit
runtime: sp=0x1fe3aab003d8 stack=[0x1fe3aab00000, 0x1fe3cab00000]
fatal error: stack overflow
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Caveats:
* t.Run() is not allowed in a buble, but it shouldn't matter much for
tests reusing engine
* oidtest and cidtest use time-based random seeds, so if time does not
advance we end up with the same IDs
Before:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/engine 21.773s
After:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/engine 19.133s
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Tests don't benefit from batching, shorter wait time reduces the overhead
significantly.
Before:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/metabase 9.696s
After:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/metabase 3.157s
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Writecache doesn't change shard behavior, there is nothing to check/wait for there. Signed-off-by: Roman Khimov <roman@nspcc.ru>
More stable and fast. Before:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard 24.716s
After:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard 22.870s
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Nothing to batch there, flush quickly. Before:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard 22.870s
After:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/shard 10.165s
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Don't wait for nothing. Before:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/engine 19.133s
After:
ok github.com/nspcc-dev/neofs-node/pkg/local_object_storage/engine 12.351s
Signed-off-by: Roman Khimov <roman@nspcc.ru>
Member
Author
|
Updated to SDK RC18, dropped useless |
carpawell
approved these changes
Mar 26, 2026
End-rey
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use more of synctest for speed and reliability. A part of #3857.