Skip to content

*: prohibit TZ hashing#3905

Draft
carpawell wants to merge 9 commits intomasterfrom
rm/tz-hash
Draft

*: prohibit TZ hashing#3905
carpawell wants to merge 9 commits intomasterfrom
rm/tz-hash

Conversation

@carpawell
Copy link
Copy Markdown
Member

@carpawell carpawell commented Mar 24, 2026

Closes #3847.

carpawell
carpawell commented Mar 24, 2026
View reviewed changes
pkg/services/object/put/local.go Outdated
checksum.SHA256,
checksum.TillichZemor:
case checksum.TillichZemor:
return errors.New("object has Tillich-Zémor checksum")
Copy link
Copy Markdown
Member Author

@carpawell carpawell Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roman-khimov, i want it to be this way, but i am not sure: we had this, and this was solved, and i really think that not all of our internals were ever ready for TZ hashing in the payload_checksum field but on the other hand, i am not sure, prohibiting it like this (even replication) is a good idea

Copy link
Copy Markdown
Member

@roman-khimov roman-khimov Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be OK, at least objects with non-SHA256 hashes are invalid as per API even not considering TZ removal.

@carpawell carpawell added the blocked Can't be done because of something label Mar 25, 2026
@carpawell
cli: do not allow TZ in RANGEHASH operation
399db4a 
Refs #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
metabase,metadata: do not pass validation of objects with TZ checksums
6d0984f 
Refs #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
node/object/put: do not pass validation of objects with TZ checksums
769795c 
Refs #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
adm: drop support of homomorphic settings
1ae4283 
The still can be read if needed as a callback for unknown fields. Refs #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
cli: do not allow searching based on homomorphic hash values
6750797 
Refs #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
node/search: do not allow searching by homomorphic hash values
ba31021 
Refs #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
go.mod: update sdk to the latest version
4bf4377 
This brings TZ hashing deprecated and unsupported.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
node: do not calculate and validate homomorphic hashes
ca0b6e9 
Refs #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
ir: drop homomorphic hashing tuning
8fcfafa 
Closes #3847.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
@carpawell
Copy link
Copy Markdown
Member Author

carpawell commented Mar 27, 2026 •
edited
Loading

There are many-many tests that use objecttest.Object() that sets homomorphic hash. We either need to unset it manually (and tests start to look strange IMO + the diff starts to look not as it was expected to be) or change it in SDK like nspcc-dev/neofs-sdk-go@2179ca1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider will be requested when the pull request is marked ready for review cthulhu-rider is a code owner

@End-rey End-rey Awaiting requested review from End-rey End-rey will be requested when the pull request is marked ready for review End-rey is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

blocked Can't be done because of something

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop TZ hash support

2 participants

@carpawell @roman-khimov