Skip to content

Buffered local EC HEAD/GET#3903

Merged
cthulhu-rider merged 2 commits intomasterfrom
ec-head-bin
Mar 26, 2026
Merged

Buffered local EC HEAD/GET#3903
cthulhu-rider merged 2 commits intomasterfrom
ec-head-bin

Conversation

@cthulhu-rider
Copy link
Copy Markdown
Contributor

@cthulhu-rider cthulhu-rider commented Mar 24, 2026

continues #3865, #3882

@cthulhu-rider cthulhu-rider force-pushed the ec-head-bin branch 2 times, most recently from 4a615bd to 1b6ac75 Compare March 24, 2026 13:20
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 78.68852% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.76%. Comparing base (264d7de) to head (8277ac3).
⚠️ Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/object/get/ec.go 0.00% 23 Missing ⚠️
pkg/services/object/get/get.go 0.00% 10 Missing and 1 partial ⚠️
pkg/metrics/engine.go 80.00% 4 Missing ⚠️
pkg/local_object_storage/engine/ec.go 98.55% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3903      +/-   ##
==========================================
+ Coverage   26.35%   26.76%   +0.41%     
==========================================
  Files         677      677              
  Lines       44242    44603     +361     
==========================================
+ Hits        11660    11940     +280     
- Misses      31495    31551      +56     
- Partials     1087     1112      +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cthulhu-rider cthulhu-rider marked this pull request as ready for review March 24, 2026 13:27
@cthulhu-rider cthulhu-rider force-pushed the ec-head-bin branch 3 times, most recently from 16f5922 to 9cbffe5 Compare March 24, 2026 14:06
roman-khimov
roman-khimov approved these changes Mar 25, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional issue for GET? Or not closing #3783 here.

@cthulhu-rider
Copy link
Copy Markdown
Contributor Author

cthulhu-rider commented Mar 25, 2026

Additional issue for GET? Or not closing #3783 here.

EC GET is out of scope here cuz it always makes assembly from multiple parts

@roman-khimov
Copy link
Copy Markdown
Member

roman-khimov commented Mar 25, 2026

OK, this one is fine for EC part and assembly is assembly.

@roman-khimov
Copy link
Copy Markdown
Member

roman-khimov commented Mar 25, 2026

Linter needs to be fixed.

@cthulhu-rider
sn/object: Do not unmarshal local EC part header in HEAD
4a59886 
Same as 637a614 and
637a614. This covers HEAD/GET requests
with EC part X-headers.

Refs #3783.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider
sn/object: Do not unmarshal local EC parent header in HEAD
8277ac3 
Same as 637a614. This covers non-local
HEAD requests in EC containers.

Note that GET is more complex, so it will be covered separately in the
future.

Closes #3783.

Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
@cthulhu-rider cthulhu-rider merged commit a66c5d8 into master Mar 26, 2026
18 of 22 checks passed
@cthulhu-rider cthulhu-rider deleted the ec-head-bin branch March 26, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@End-rey End-rey Awaiting requested review from End-rey End-rey is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cthulhu-rider @roman-khimov