Skip to content

Storage shard id generation #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
End-rey wants to merge 2 commits into
base: master
Choose a base branch
from

storage: move shard ID ownership to fstree

4c4a082
Select commit
Loading
Failed to load commit list.
Open

Storage shard id generation #3889

storage: move shard ID ownership to fstree
4c4a082
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 27, 2026 in 1s

26.77% (-0.02%) compared to 60d685f, passed because coverage increased by 0.04% when compared to adjusted base (26.72%)

View this Pull Request on Codecov

26.77% (-0.02%) compared to 60d685f, passed because coverage increased by 0.04% when compared to adjusted base (26.72%)

Details

Codecov Report

❌ Patch coverage is 40.61303% with 155 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.77%. Comparing base (60d685f) to head (4c4a082).

Files with missing lines Patch % Lines
pkg/local_object_storage/blobstor/common/id.go 40.62% 17 Missing and 2 partials ⚠️
pkg/local_object_storage/metabase/shard_id.go 13.63% 19 Missing ⚠️
pkg/local_object_storage/shard/control.go 52.50% 10 Missing and 9 partials ⚠️
...kg/local_object_storage/blobstor/fstree/control.go 58.97% 13 Missing and 3 partials ⚠️
pkg/services/control/server/helpers.go 0.00% 11 Missing ⚠️
cmd/neofs-lancet/internal/meta/resync.go 0.00% 8 Missing ⚠️
pkg/local_object_storage/blobstor/fstree/fstree.go 12.50% 7 Missing ⚠️
pkg/local_object_storage/metabase/control.go 44.44% 4 Missing and 1 partial ⚠️
pkg/local_object_storage/engine/shards.go 80.95% 3 Missing and 1 partial ⚠️
...cal_object_storage/internal/storagetest/storage.go 0.00% 4 Missing ⚠️
... and 25 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3889      +/-   ##
==========================================
- Coverage   26.78%   26.77%   -0.02%     
==========================================
  Files         677      677              
  Lines       44616    44665      +49     
==========================================
+ Hits        11952    11957       +5     
- Misses      31553    31593      +40     
- Partials     1111     1115       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov