feat(note-list): add option to disable swipe actions#3088
Open
markus-kreft wants to merge 1 commit intonextcloud:mainfrom
Open
feat(note-list): add option to disable swipe actions#3088markus-kreft wants to merge 1 commit intonextcloud:mainfrom
markus-kreft wants to merge 1 commit intonextcloud:mainfrom
Conversation
Member
|
@markus-kreft code looks good, still will need to test it though. Can you sign the commits/DCO, see https://github.com/nextcloud/notes-android/pull/3088/checks?check_run_id=65779085624 for details on how to do it. |
Add a toggle in the "Appearance and behavior" settings to enable or disable swipe gestures (delete and favorite) in the note list. The default value is set to enabled, preserving existing behavior while allowing users who accidentally trigger these actions to disable them. Changes: - Add `swipe_actions` preference to `preferences.xml` - Add `isSwipeEnabled` global state in `NotesApplication` - Update `NotesListViewItemTouchHelper` to respect the setting - Create `ic_swipe_grey600_24dp.xml` for the settings icon Signed-off-by: Markus Kreft <129367085+markus-kreft@users.noreply.github.com>
markus-kreft
force-pushed
the
feat/disable-swipe-actions
branch
from
ba14d75 to
5206334
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a toggle in Settings > Appearance and behavior to enable or disable swipe gestures (delete and favorite) in the note list.
Motivation
Destructive actions like deletion can currently be triggered too easily by accident. I experienced this when I unknowingly deleted a note via a swipe and only noticed it two weeks later. While the "Undo" snackbar is helpful, it is easy to miss. This option allows users to make deletions more intentional via the long-press menu.
Changes
ItemTouchHelpergestures when the setting is toggled off.ic_swipe_grey600_24dp.xml) for the settings entry.Testing
Addresses #1774