feat: add maximum submissions limit for forms#3199
feat: add maximum submissions limit for forms#3199LAfricain wants to merge 18 commits intonextcloud:mainfrom
Conversation
Add the ability to limit the number of responses a form can receive. When the limit is reached, the form is automatically closed and displays a dedicated message instead of accepting new submissions. - Add max_submissions column to forms_v2_forms table (migration) - Add maxSubmissions property to Form entity - Check submission limit in FormsService::canSubmit() - Add limit enforcement in ApiController::newSubmission() - Add isMaxSubmissionsReached flag in form API response - Add limit settings UI in SettingsSidebarTab - Display dedicated 'Form is full' message in Submit view - Add French translations for new strings Closes nextcloud#596
Chartman123
left a comment
There was a problem hiding this comment.
@LAfricain thanks for your PR. I just had a quick look at your code and didn't test it yet in my instance. Already a few comments. :)
Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be>
Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be>
Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be>
Chartman123
left a comment
There was a problem hiding this comment.
Some more comments :) Please have a look at the failing workflows, too.
Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be>
Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be>
Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be>
Co-authored-by: Christian Hartmann <chris-hartmann@gmx.de> Signed-off-by: L'Africain <fr.cyrille@tiberiade.be>
|
Hello @Chartman123, |
|
@LAfricain sorry, I don't have much spare time at the moment :) Please fix the remaining workflow issues |
It's Ok, no rush. I didn't realize I had to fix the errors myself; I still need to get used to the tool. It's done now. |
|
@LAfricain yes, you have to fix them yourself (or use the npm scripts and php scripts). Environments like VSCode also can assist you with that :) |
Add the ability to limit the number of responses a form can receive. When the limit is reached, the form is automatically closed and displays a dedicated message instead of accepting new submissions.
Closes #596